Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET 6/.NET Core 3.1 targets #1342

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

lnetrebskii
Copy link

@lnetrebskii lnetrebskii commented Nov 17, 2022

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

Support of .NET 6 and .NET Core 3.1 has been added. The projects converted to .NET SDK format.

Issues addressed

  • .net 4.6.1 makes it challenged to use this package together with others which are developed for .NET Core/NET 6.

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@lnetrebskii lnetrebskii marked this pull request as ready for review November 17, 2022 12:55
@jummans
Copy link

jummans commented Mar 20, 2023

Do we know how long this migration to version 6 approval will take place ?

@AngelRodriguez8008
Copy link
Contributor

Hi @lnetrebskii

I will prefer not to merge this Branch to develop and just to keep .NET Core as a separate branch.

I see that you remove functionality like Take Screenshot, I use it.

I want also to remove things, for example, the whole old WEB logic.

I think .NET Core Support is an excellent point to clean up all old things in a new, straight forward branch, that in the future may become the main branch. But not merging, just droping the old code.

@Shakevg
Copy link
Contributor

Shakevg commented Mar 29, 2024

lnetrebskii Could you please fix merge conflicts.
TYLEROL Could you please create separate branch with separate Nuget for .Net Core and let's use it until we complete all fixes for .Net.
But I think we need to start use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants